Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CustomOp] Automatically specify PADDLE_WITH_MKLDNN & Remove Interpreter argument #31391

Merged
merged 5 commits into from
Mar 8, 2021
Merged

[CustomOp] Automatically specify PADDLE_WITH_MKLDNN & Remove Interpreter argument #31391

merged 5 commits into from
Mar 8, 2021

Conversation

Aurelius84
Copy link
Contributor

PR types

Others

PR changes

APIs

Describe

  • Automatically specify PADDLE_WITH_MKLDNN
  • Remove Interpreter argument in load API

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chenwhql
chenwhql previously approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhwesky2010
zhwesky2010 reviewed Mar 3, 2021
View reviewed changes
python/paddle/fluid/tests/custom_op/utils.py Outdated
] if six.PY2 and not IS_WINDOWS else []
# Test for extra compile args
extra_cc_args = ['-w', '-g']
extra_nvcc_args = ['-O2']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release下用O3吧。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是用来测试单测的，没有影响。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来的-O3被删了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,done

python/paddle/fluid/tests/custom_op/utils.py Outdated
extra_compile_args = ['-DPADDLE_WITH_MKLDNN'
] if six.PY2 and not IS_WINDOWS else []
# Test for extra compile args
extra_cc_args = ['-w', '-g']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里加个Windows分支吧，Windows下没有 '-w', '-g'，可以用空，或者'/w'
Linux下用这个

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-g -w这些选项是不是比较通用，直接给用户写到extension_util里固定住。这里适合放一些额外的选项

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

zhwesky2010
zhwesky2010 approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit fadabbe into PaddlePaddle:develop Mar 8, 2021
@Aurelius84 Aurelius84 mentioned this pull request May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

@zhhsplendid zhhsplendid Awaiting requested review from zhhsplendid

@JiabinYang JiabinYang Awaiting requested review from JiabinYang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aurelius84 @chenwhql @zhwesky2010