Fix ninja compilation bug and warning on windows #32987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
b32fe44 to
dc4e610
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
dc4e610 to
e8d74a3
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
e8d74a3 to
e6a32f4
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
e6a32f4 to
07b810f
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
07b810f to
978dc6f
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
978dc6f to
2dd83e1
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
2dd83e1 to
f2810c8
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
f2810c8 to
d7e2489
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
d7e2489 to
c97cfdf
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
c97cfdf to
be975ae
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
2 times, most recently
from
0bba9af to
e8e05d4
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
e8e05d4 to
4ebdfd8
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
4ebdfd8 to
e98c2e3
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
d6aec2d to
7a088c6
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
7a088c6 to
5bc52bb
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
5bc52bb to
48f7c22
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
48f7c22 to
f2ad9b9
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
f2ad9b9 to
a4e9177
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
8fffa6f to
19ec2de
Compare
Avin0323
reviewed
May 25, 2021
| "Choose the type of build, options are: Debug Release RelWithDebInfo MinSizeRel" | ||
| FORCE) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
写的靠后无法生效，Ninja在project后设置CMAKE_BUILD_TYPE为Debug，导致Release的默认参数失效
Avin0323
reviewed
May 25, 2021
| BUILD_ALWAYS 1 | ||
| # UPDATE_COMMAND "" | ||
| UPDATE_COMMAND "" | ||
| #BUILD_ALWAYS 1 |
There was a problem hiding this comment.
不影响Ninja，这个BUILD_ALWAYS导致mkldnn、warpctc增量编译失效，0改动完全重编
Avin0323
reviewed
May 25, 2021
| PATCH_COMMAND "" | ||
| BUILD_ALWAYS 1 | ||
| #BUILD_ALWAYS 1 |
Avin0323
reviewed
May 25, 2021
| if(NOT WIN32) | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14") | ||
| else() | ||
| set(CMAKE_CXX_STANDARD 14) |
There was a problem hiding this comment.
set(CMAKE_CXX_STANDARD 14)之后，在linux、mac上是不是也不用再单独设置CMAKE_CXX_FLAGS了？
There was a problem hiding this comment.
Linux mac下CMAKE_CXX_STANDARD=14有编译wanring，没有改动，
VS下-std=c++14没有生效，会屏蔽这个flag，所以也没warning，但Ninja不会屏蔽，导致所有cl报warning
Avin0323
reviewed
May 25, 2021
| @@ -412,10 +412,10 @@ if "%WITH_TESTING%"=="ON" ( | |||
|
|
|||
| echo Build Paddle the %build_times% time: | |||
| if %GENERATOR% == "Ninja" ( | |||
| ninja -j %PARALLEL_PROJECT_COUNT% | |||
| ninja all | |||
There was a problem hiding this comment.
这里的不指定-j会不会造成并行过高而影响编译时间？
There was a problem hiding this comment.
应该不会，之前是由于/m 和/MP 累乘，导致编译进程有核数的平方，而ninja默认并行思路就是核数大小，降了可能会变慢，先用默认的看看
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
125e6c1 to
e2e4791
Compare
zhwesky2010
force-pushed
the
fix_windows_ci3
branch
from
e2e4791 to
b04c06d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
1.fix ninja compilation MSVC(/MT and /MD flags) bug.
2.fix ninja compilation warning on windows.