Support npu kernel for tile op #34606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
|
LGTM |
qili93
reviewed
Aug 5, 2021
|
|
||
| namespace paddle { | ||
| namespace operators { | ||
| inline std::vector<int> get_repeat_times_npu( |
There was a problem hiding this comment.
这个函数不需要重写，修改一下tile_op.h的判断，改为就可以了
if (platform::is_gpu_place(repeat_tensor->place()) || platform::is_npu_place(repeat_tensor->place())) {
| self.check_output_with_place(self.place) | ||
|
|
||
| def test_check_grad(self): | ||
| self.check_grad(['X'], 'Out') |
| self.check_output_with_place(self.place) | ||
|
|
||
| def test_check_grad(self): | ||
| self.check_grad(['X'], 'Out') |
There was a problem hiding this comment.
没有实现tile_grad的话，把这个函数改成 pass就好了
| self.check_output_with_place(self.place) | ||
|
|
||
| def test_check_grad(self): | ||
| self.check_grad(['X'], 'Out') |
| # Test python API | ||
| class TestTileAPI(unittest.TestCase): | ||
| def test_api(self): | ||
| with fluid.dygraph.guard(): |
There was a problem hiding this comment.
可以改成 fluid.dygraph.guard(paddle.NPUPlace(0)): 后面 to_tensor就不需要加NPUPlace了
qili93
requested changes
Aug 6, 2021
| "must be less than or equal to %d, but the value received is %d.", | ||
| MAX_RANK_SUPPORTED, repeat_times_size)); | ||
| rank = std::max(rank, repeat_times_size); | ||
| switch (rank) { REP_TILE_TEMPLATE(MAX_RANK_SUPPORTED) } |
There was a problem hiding this comment.
这个在NPU下有编译错误，需要根据最新develop分支的代码修改一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Support npu kernel for tile op
