Kernel primitives api #34672
Merged
Kernel primitives api #34672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
xingfeng01
reviewed
Aug 9, 2021
paddle/fluid/operators/kernel_primitives/datamover_primitives.h
Outdated
Show resolved
Hide resolved
| namespace kernel_primitives {} | ||
| namespace kernel_primitives { | ||
|
|
||
| template <typename T, int VecSize> |
There was a problem hiding this comment.
建议把内部的函数包到detail namespace 下面，类似于 MPType 那里。
paddle/fluid/operators/kernel_primitives/datamover_primitives.h
Outdated
Show resolved
Hide resolved
xingfeng01
reviewed
Aug 9, 2021
paddle/fluid/operators/kernel_primitives/datamover_primitives.h
Outdated
Show resolved
Hide resolved
|
LGTM |
lanxianghit
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
添加Kernel primitives api： ReadData, WriteData ComputeFunctor