[Fleet_Executor] Passing runtime scope and place #37603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
LiYuRio
force-pushed
the
dev_exe_scope_place
branch
from
7dce858 to
7970582
Compare
LiYuRio
force-pushed
the
dev_exe_scope_place
branch
from
23bd963 to
9da8f33
Compare
wangxicoding
previously approved these changes
Nov 26, 2021
| @@ -97,8 +113,25 @@ void FleetExecutor::Run() { | |||
| carrier_instance.Start(); | |||
| } | |||
|
|
|||
| void FleetExecutor::Release() { | |||
| // Release | |||
| void FleetExecutor::Release() { root_scope_->DropKids(); } | |||
There was a problem hiding this comment.
这个是不是加到析构里面就可以了，当前机制FleetExecutor应该是默认搞成program_cache的
There was a problem hiding this comment.
因为有个Init，所以当时加了个Release从语义上和它对应，就像Trainer一样，虽然讲道理我也觉得不需要
FeixLiu
force-pushed
the
dev_exe_scope_place
branch
3 times, most recently
from
9da8f33 to
f7d118f
Compare
FeixLiu
force-pushed
the
dev_exe_scope_place
branch
from
f7d118f to
b5062f6
Compare
wangxicoding
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
异步执行器传递运行时的scope和place。