[fleet_executor] Add interceptor gc #37889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
FeixLiu
reviewed
Dec 7, 2021
| } | ||
| // The carrier will be always waiting for outside initializer | ||
| // since there is no interceptor has been created during auto init | ||
| creating_flag_mutex_.lock(); |
There was a problem hiding this comment.
为啥把这个放在外面了。。。
之前的判断逻辑是，如果没有默认的config，那么一定要是外部创建，外部就无需多调用一次SetCreatingFlag操作。这么改完是不是那几个单测都要set一下flag为true？
wangxicoding
force-pushed
the
add_interceptor_gc
branch
from
71fe0a7 to
d24fb68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Add interceptor gc