Add GetBasePtr interface in paddle::memory #39145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
After PR #38853 merged, the memory::allocation::Allocation is a derived class of pten::Allocation, and the Alloc interface in malloc.h return a pten::Allocation type. Since the base_ptr function introduced in #37978 is implenmemted in memoy::allocation::Allocation, now we have to get the base-pointer from an allocation like:
It is so inconvenient compared with the previous method:
This PR adds a GetBasePtr interface in paddle::memory that hides the inelegant static_cast in AllocatorFacadePrivate, therefore we can get the base-pointer by a simple way like:
void* base_ptr = memory::GetBasePtr(allocation);