[phi]migrate increment addmm multinomial cholesky kernels to phi #39858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aganlengzi
requested review from
YuanRisheng,
zyfncg,
MingMingShangTian and
chenwhql
| const DenseTensor& x, | ||
| int num_samples, | ||
| bool replacement, | ||
| DenseTensor* out); | ||
|
|
||
| template <typename T> | ||
| void MultinomialFunctor(int64_t* out_data, const T* in_data, |
There was a problem hiding this comment.
MultinomialFunctor 不要放到kernel 声明的头文件中，可以放到paddle/phi/kernels/funcs 下
There was a problem hiding this comment.
多谢，我在迁InferShape函数的PR中修改.
chenwhql
approved these changes
Feb 24, 2022
| @@ -0,0 +1,28 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
|
|
||
| namespace phi { | ||
|
|
||
| KernelSignature AddmmOpArgumentMapping(const ArgumentMappingContext& ctx) { |
There was a problem hiding this comment.
这个和opmaker的顺序一致，后面PR应该可以删除
There was a problem hiding this comment.
了解，InferShape迁移中会移除。
|
|
||
| namespace phi { | ||
|
|
||
| KernelSignature CholeskyOpArgumentMapping(const ArgumentMappingContext& ctx) { |
There was a problem hiding this comment.
同上，应该也不需要写，默认生成的就可以用，这些ArgumentMapping函数之所以放到compat目录下，就是希望将来可以移除的，所以我们不写不必要的
There was a problem hiding this comment.
了解，InferShape迁移中会移除。
raindrops2sea
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Migrate increment addmm multinomial and cholesky kernel to phi.
TODO: migrate InferShape funcs. move MultinomialFunctor to paddle/phi/kernels/funcs.