[Phi] Migrate multiplex, qr, tril_triu op kernel to phi #40007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
paddle/phi/kernels/cpu/qr_kernel.cc
Outdated
|
|
||
| namespace phi { | ||
|
|
||
| static inline std::tuple<bool, bool> _parse_qr_mode(const std::string& mode) { |
There was a problem hiding this comment.
_parse_qr_mode 这个函数命名不合规范，改为驼峰式
| @@ -16,17 +16,16 @@ | |||
|
|
|||
| #include "paddle/phi/kernels/triangular_solve_grad_kernel.h" | |||
|
|
|||
| #include "paddle/fluid/platform/for_range.h" | |||
There was a problem hiding this comment.
使用phi下的这个头文件 paddle/phi/kernels/funcs/for_range.h
|
|
||
| #include "paddle/phi/kernels/tril_triu_grad_kernel.h" | ||
|
|
||
| #include "paddle/fluid/platform/for_range.h" |
|
|
||
| #include "paddle/phi/kernels/tril_triu_kernel.h" | ||
|
|
||
| #include "paddle/fluid/platform/for_range.h" |
| #pragma once | ||
|
|
||
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/kernels/funcs/eigen/common.h" |
There was a problem hiding this comment.
thx, already removed
YuanRisheng
reviewed
Mar 10, 2022
| @@ -145,8 +145,6 @@ REGISTER_OPERATOR(qr, ops::QrOp, ops::QrOpMaker, | |||
|
|
|||
| REGISTER_OPERATOR(qr_grad, ops::QrGradOp); | |||
|
|
|||
| REGISTER_OP_CPU_KERNEL(qr, ops::QrCPUKernel<float>, ops::QrCPUKernel<double>); | |||
|
|
|||
| REGISTER_OP_CPU_KERNEL( | |||
There was a problem hiding this comment.
是的，因为有依赖，后续由威行或威行解完依赖我再迁移
|
|
||
| #include "paddle/phi/kernels/multiplex_kernel.h" | ||
|
|
||
| #include "paddle/phi/api/lib/utils/tensor_utils.h" |
Caozhou1995
force-pushed
the
migrate_phi
branch
from
56597a9 to
f957905
Compare
Caozhou1995
force-pushed
the
migrate_phi
branch
from
f957905 to
ae55ca6
Compare
YuanRisheng
approved these changes
Mar 15, 2022
MingMingShangTian
approved these changes
Mar 15, 2022
chenwhql
approved these changes
Mar 16, 2022
|
|
||
| template <typename T, typename Context> | ||
| void MultiplexKernel(const Context& ctx, | ||
| const std::vector<DenseTensor*>& ins, |
There was a problem hiding this comment.
需要用const std::vector<const DenseTensor*>& ins
liqitong-a
pushed a commit
to liqitong-a/Paddle
that referenced
this pull request
Mar 17, 2022
…#40007) * migrate multiplex op kernel * migrate qr cpu kernel * migrate tril_triu op kernel * fix multiplex kernel * add kernel sig * fix dependence and bug * fix multiplex error * fix npu include error * fix conflict * fix conflict and delete tril_triu * fix date and multiplex input * adapt header file order * fix header file include * fix conflict * delete cholesky_solve_op.h * delete triangular_solve_op.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
This pr migrate kernel and grad kernel on the cpu and gpu of multiplex, cpu kernel of qr, kernel and grad kernel on the cpu and gpu of tril_triu to phi.