support view strategy in dygraph eager_final state #40891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
pangyoki
force-pushed
the
support_view_in_eager_final
branch
from
b128578 to
de41fed
Compare
… support_view_in_eager_final
… support_view_in_eager_final
… support_view_in_eager_final
zyfncg
previously approved these changes
Mar 29, 2022
| inplace : (x -> out) | ||
| view: (x -> out) | ||
| intermediate : xshape | ||
| no_need_buffer: xshape |
There was a problem hiding this comment.
这里的xshape需不需要使用no_need_buffer？
There was a problem hiding this comment.
不需要使用no_need_buffer，已删除
Comment on lines
278
to
293
| def parse_inplace_or_view(self, api_item_yaml, mode='inplace'): | ||
| if mode in api_item_yaml: | ||
| inplace_view_map = {} | ||
| in_out_mapping_list = api_item_yaml[mode].split(',') | ||
| for item in in_out_mapping_list: | ||
| result = re.search(r"(?P<in>\w+)\s*->\s(?P<out>\w+)", item) | ||
| in_val = result.group('in') | ||
| out_val = result.group('out') | ||
| assert in_val in self.inputs['names'], \ | ||
| f"{self.api} : Inplace input error: the input var name('{in_val}') is not found in the input args of {self.api}." | ||
| f"{self.api} : {mode} input error: the input var name('{in_val}') is not found in the input args of {self.api}." | ||
| assert out_val in self.outputs['names'], \ | ||
| f"{self.api} : Inplace output error: the output var name('{out_val}') is not found in the output args of {self.api}." | ||
| f"{self.api} : {mode} output error: the output var name('{out_val}') is not found in the output args of {self.api}." | ||
|
|
||
| inplace_map[out_val] = in_val | ||
| inplace_view_map[out_val] = in_val | ||
|
|
||
| return inplace_map | ||
| return inplace_view_map |
There was a problem hiding this comment.
这里感觉不传mode参数，直接一次返回inplace和view两个map看上去会更直观一些
YuanRisheng
previously approved these changes
Mar 29, 2022
jim19930609
approved these changes
Mar 30, 2022
zyfncg
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
为新动态图最终态添加View机制：
reshape、squeeze、unsqueeze、flatten。目前只为
reshape添加了view机制，等其他op的yaml文件ready了之后再添加view机制。