-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NewIR]Replace frontend::Program & hlir::Graph with ::ir::Program in CINN #55186
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
✅ This PR's description meets the template requirements! |
1056850
to
2dc6cbc
Compare
a978e4f
to
69e99df
Compare
fix compilation problem fix conflict fix conflict fix unittest fix unittet fix cmake fix cmake
#include "paddle/fluid/ir/dialect/pd_attribute.h" | ||
#include "paddle/phi/common/data_type.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cinn对于其他目录的头文件依赖目前有约束要求吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果有依赖约束,那可能需要看怎么统一Paddle和CINN底层数据结构了,比如这里的datatype,是否可以独立出来。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我来记一下这个TODO,因为目前发现还有很多其他基础数据结构需要独立和统一的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
Others
Description
Pcard-67164
What's New?
see:#56880
以GraphCompiler组件为切入点,解耦CINN框架中的 frontend::Program 和 hlir::frameowork::Graph 与后端AST的依赖,新增 NewIRCompiler,直接上承 ::ir::Program,下接 AST 和 LowerFunc。
为了尽可能保证不影响现有CINN自身的迭代,此PR以及后续适配工作都将「新增并行模块」,方便后续一键切换。
此机制打通工作分为如下几个阶段:
TODO项: