Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semi-Auto] Add transpose spmd rule #55350

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

pkuzyc
Copy link
Contributor

@pkuzyc pkuzyc commented Jul 12, 2023

PR types

New features

PR changes

Others

Description

Pcard-70448

  1. add forward spmd rule of transpose for auto parallel.
  2. fix some typo and bugs in common functions.

@paddle-bot
Copy link

paddle-bot bot commented Jul 12, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 21, 2023

Sorry to inform you that bddebb2's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

JZ-LIANG
JZ-LIANG previously approved these changes Jul 21, 2023
Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


// Step2.3 handle input tensor partial (TODO)
VLOG(4) << "TransposeSPMDRule InferForward:";
for (int64_t i = 0; i < ninputs; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log should print attr that would effect spmd inference, like perm here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JZ-LIANG JZ-LIANG merged commit f6161d1 into PaddlePaddle:develop Jul 24, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
* [Semi-Auto] Add transpose spmd rule

* add unit test in cmake file

* log perm info
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
* [Semi-Auto] Add transpose spmd rule

* add unit test in cmake file

* log perm info
@pkuzyc pkuzyc deleted the transpose_rule branch August 14, 2023 02:18
jinjidejinmuyan pushed a commit to jinjidejinmuyan/Paddle that referenced this pull request Aug 30, 2023
* [Semi-Auto] Add transpose spmd rule

* add unit test in cmake file

* log perm info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants