【静态图性能优化】图依赖信息复用 #55389
Merged
【静态图性能优化】图依赖信息复用 #55389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
From00
reviewed
Jul 17, 2023
| // first job to other jobs. The shared build result includes op dependency, | ||
| // event analyzer, thread scheduling and GC. | ||
| for (const auto& pair : type_to_id) { | ||
| const auto& idx = pair.second; |
There was a problem hiding this comment.
Suggested change
| const auto& idx = pair.second; | |
| const auto& ids = pair.second; |
idx是单数，ids是复数。
| @@ -115,6 +117,10 @@ class ProgramInterpreter : public InterpreterBaseImpl { | |||
| // workqueue | |||
| std::shared_ptr<interpreter::AsyncWorkQueue> GetWorkQueue(); | |||
|
|
|||
| // op dependences | |||
| interpreter::DependencyBuilder* GetDependencyBuilder(); | |||
| std::shared_ptr<std::vector<size_t>> GetDependecyCount(); | |||
There was a problem hiding this comment.
Suggested change
| std::shared_ptr<std::vector<size_t>> GetDependecyCount(); | |
| std::shared_ptr<std::vector<size_t>> GetDependencyCount(); |
| @@ -311,6 +322,17 @@ ProgramInterpreter::GetWorkQueue() { | |||
| return async_work_queue_; | |||
| } | |||
|
|
|||
| interpreter::DependencyBuilder* ProgramInterpreter::GetDependencyBuilder() { | |||
| return &dependency_builder_; | |||
There was a problem hiding this comment.
这里是 dependency_builder_ 下的成员变量进行共享，dependency_builder_ 也需要进行生命周期管理吗
There was a problem hiding this comment.
done, 换成了返回一个const引用
Comment on lines
288
to
291
| dependency_builder_.ShareDependencyFrom( | ||
| reinterpret_cast<ProgramInterpreter*>(src)->GetDependencyBuilder()); | ||
| dependecy_count_ = | ||
| reinterpret_cast<ProgramInterpreter*>(src)->GetDependecyCount(); |
There was a problem hiding this comment.
建议GetDependencyBuilder和GetDependecyCount也通过虚函数的方式实现多态，避免使用reinterpret_cast。
| } | ||
|
|
||
| std::shared_ptr<std::vector<size_t>> ProgramInterpreter::GetDependecyCount() { | ||
| if (dependecy_count_ == nullptr) { |
There was a problem hiding this comment.
dependecy_count_不需要延迟创建，可以直接在构造函数中创建。这样GetDependencyBuilder和GetDependencyCount都可以声明成const函数。
| @@ -123,6 +129,7 @@ class ProgramInterpreter : public InterpreterBaseImpl { | |||
|
|
|||
| bool is_build_{false}; | |||
| bool static_build_{false}; | |||
| bool is_shared_{false}; | |||
| @@ -283,6 +283,17 @@ void ProgramInterpreter::ShareWorkQueueFrom(InterpreterBaseImpl* src) { | |||
| << ") to InterpreterCore(" << this << ")"; | |||
| } | |||
|
|
|||
| void ProgramInterpreter::ShareBuildResultsFrom(InterpreterBaseImpl* src) { | |||
There was a problem hiding this comment.
Suggested change
| void ProgramInterpreter::ShareBuildResultsFrom(InterpreterBaseImpl* src) { | |
| void ProgramInterpreter::ShareBuildResultsFrom(const InterpreterBaseImpl& src) { |
非可选输入参数通常是值参或 const 引用, 非可选输出参数或输入/输出参数通常应该是引用 （不能为空）.
| } | ||
|
|
||
| void ShareDependencyFrom(DependencyBuilder* src); |
There was a problem hiding this comment.
Suggested change
| void ShareDependencyFrom(DependencyBuilder* src); | |
| void ShareDependencyFrom(const DependencyBuilder& src); |
| std::tuple<std::shared_ptr<std::map<size_t, std::set<size_t>>>, | ||
| std::shared_ptr<std::vector<std::vector<bool>>>> | ||
| DependencyBuilder::GetDependency() { | ||
| if (op_downstream_map_ == nullptr || op_happens_before_ == nullptr) { |
… share_build_results
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
* add share api for DependencyBuilder * add judge codes for sharing build results * add ShareBuildResultsFrom * update ShareDependencyFrom * fix error * add share codes * fix memory error * update according review * update notes * fix code style * remove const_cast * fix code style
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
* add share api for DependencyBuilder * add judge codes for sharing build results * add ShareBuildResultsFrom * update ShareDependencyFrom * fix error * add share codes * fix memory error * update according review * update notes * fix code style * remove const_cast * fix code style
Closed
jinjidejinmuyan
pushed a commit
to jinjidejinmuyan/Paddle
that referenced
this pull request
Aug 30, 2023
* add share api for DependencyBuilder * add judge codes for sharing build results * add ShareBuildResultsFrom * update ShareDependencyFrom * fix error * add share codes * fix memory error * update according review * update notes * fix code style * remove const_cast * fix code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
在Paddle中，图依赖分析（op dependency）发生在Convert过程中，其依赖分析过程在BuildOperatorDependences 构建。图依赖分析的主要作用是分析 op 之间的依赖关系，对计算图进行解析和分析，构建出每个算子的调度关系和执行顺序，以保证正确的计算顺序和结果。对于一样的子图，图依赖分析的结果是一样的，因此可以进行复用。
详细介绍见Issue：