Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] enable modernize-use-override #55491

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[clang-tidy] enable modernize-use-override #55491

merged 1 commit into from
Jul 21, 2023

Conversation

BeingGod
Copy link
Contributor

@BeingGod BeingGod commented Jul 18, 2023 •
edited by GreatV
Loading

PR types

Others

PR changes

Others

Description

enable modernize-use-override on clang-tidy

@paddle-bot
Copy link

paddle-bot bot commented Jul 18, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 18, 2023
@GreatV GreatV mentioned this pull request Jul 18, 2023
Open
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 18, 2023
GreatV
GreatV reviewed Jul 18, 2023
View reviewed changes
.clang-tidy Outdated Show resolved Hide resolved
@BeingGod BeingGod force-pushed the modernize_use_override branch from ebf0543 to b2271a4 Compare July 18, 2023 08:02
@BeingGod
Copy link
Contributor Author

求助：在重新触发PR-CI-Windows-Inference时显示没有权限

@luotao1
Copy link
Contributor

luotao1 commented Jul 19, 2023

Windows-Inference 已经在排队中了

@BeingGod
Copy link
Contributor Author

这个可以合入了吗？

@luotao1 luotao1 requested a review from zhangbo9674 July 21, 2023 07:36
risemeup1
risemeup1 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Galaxy1458
Galaxy1458 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@Galaxy1458 Galaxy1458 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit cd0f152 into PaddlePaddle:develop Jul 21, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
@BeingGod @cqulilujia
[clang-tidy] enable modernize-use-override (PaddlePaddle#55491)
4f4768c
@BeingGod BeingGod deleted the modernize_use_override branch July 24, 2023 12:25
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
@BeingGod @wz1qqx
[clang-tidy] enable modernize-use-override (PaddlePaddle#55491)
5442453
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
jinjidejinmuyan pushed a commit to jinjidejinmuyan/Paddle that referenced this pull request Aug 30, 2023
@BeingGod
[clang-tidy] enable modernize-use-override (PaddlePaddle#55491)
1382688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreatV GreatV GreatV left review comments

@Galaxy1458 Galaxy1458 Galaxy1458 approved these changes

@risemeup1 risemeup1 risemeup1 approved these changes

@zhangbo9674 zhangbo9674 Awaiting requested review from zhangbo9674

Assignees

@luotao1 luotao1

@zhangbo9674 zhangbo9674

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BeingGod @luotao1 @GreatV @Galaxy1458 @risemeup1 @zhangbo9674