[IR] Add Construct event for new ir interpretercore #55555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… dev/construct_event
… dev/construct_event
… dev/construct_event
zhangbo9674
requested review from
Aurelius84,
phlrain,
winter-wang,
kangguangli and
From00
Aurelius84
previously approved these changes
Jul 26, 2023
| VLOG(6) << "finish process device context"; | ||
|
|
||
| Scope* inner_scope = local_scope == nullptr ? scope : local_scope; | ||
| InitInputsOutputsIds( | ||
| op, inner_scope, value_2_var_name, var_name_2_id, variable_2_var_name); | ||
| VLOG(6) << "finish process inputs outputs index"; | ||
|
|
||
| auto no_need_buffer_ids = yaml_info_parser.NoNeedBufferIds(); |
There was a problem hiding this comment.
auto 会隐式触发copy，如果接口返回的是引用，这里建议用auto &
From00
reviewed
Jul 26, 2023
|
|
||
| std::unordered_map<ir::Value, std::vector<int>> output_index_; | ||
| std::unordered_set<::ir::Value> no_need_buffer_; |
There was a problem hiding this comment.
Suggested change
| std::unordered_set<::ir::Value> no_need_buffer_; | |
| std::unordered_set<::ir::Value> no_need_buffer_values_; |
| @@ -32,6 +34,114 @@ | |||
| namespace paddle { | |||
| namespace framework { | |||
|
|
|||
| using DeviceContext = paddle::platform::DeviceContext; | |||
|
|
|||
| class IrContextManager { | |||
There was a problem hiding this comment.
ContextManager并不依赖新IR，为何也需要重复一份？
| auto no_need_buffer_ids = yaml_info_parser.NoNeedBufferIds(); | ||
| std::unordered_set<::ir::Value> no_need_buffer_values; | ||
| for (size_t id = 0; id < no_need_buffer_ids.size(); id++) { | ||
| no_need_buffer_values.insert(op->operand(id)); |
There was a problem hiding this comment.
no_need_buffer_ids里的元素一定是从0开始连续递增的吗？
| @@ -550,8 +550,7 @@ void DependencyBuilder::ShrinkDownstreamMap() { | |||
| /// For new ir /// | |||
| /// ======================== /// | |||
| const std::map<size_t, std::set<size_t>>& IrDependencyBuilder::Build( | |||
| const std::vector<std::unique_ptr<paddle::framework::InstructionBase>>& | |||
| instructions) { | |||
| const std::vector<paddle::framework::InstructionBase*>& instructions) { | |||
| @@ -173,6 +178,10 @@ bool IsMemcpyH2D(const Instruction& instr) { | |||
| return instr.OpBase()->Type() == kMemcpyH2D; | |||
| } | |||
|
|
|||
| bool IsMemcpyH2D(const paddle::framework::InstructionBase* instr) { | |||
There was a problem hiding this comment.
InstructionBase的命名容易被误认为是两套Insturction的公共基类，但其实现却是针对新IR的，且同文件下又有一个以Instruction对象作为入参的IsMemcpyH2D函数，令人困惑。
There was a problem hiding this comment.
由于是中间态，最终态下 NewIR 的执行器中，将不会存在 Instruction 的相关信息
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
基于新 IR InstructionBase 体系，支持 ConstructEvent 模块。
后续工作：
Others
Pcard-67164