Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix bug of UserWarnings in test_layer_norm_op.py #55762

Merged

Conversation

RedContritio
Copy link
Contributor

@RedContritio RedContritio commented Jul 27, 2023

PR types

Bug fixes

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented Jul 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 27, 2023
@RedContritio RedContritio changed the title [BugFix] fix bug of invalid arguments in test_layer_norm_op.py [BugFix] fix bug of invalid parameters in test_layer_norm_op.py Jul 27, 2023
@RedContritio RedContritio changed the title [BugFix] fix bug of invalid parameters in test_layer_norm_op.py [BugFix] fix bug of UserWarnings in test_layer_norm_op.py Jul 27, 2023
@RedContritio
Copy link
Contributor Author

@luotao1

@luotao1 luotao1 self-assigned this Jul 31, 2023
@luotao1
Copy link
Contributor

luotao1 commented Jul 31, 2023

@Wong4j Please review this PR

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wong4j
Copy link
Collaborator

Wong4j commented Jul 31, 2023

Hi @RedContritio , 感谢帮忙

  • param_attrbias_attr相关的Warning解决了。
  • skip bf16相关的改动合理,但并不是root cause。我报告这个issue的时候就是在A100上测试的。我刚才再次在A100上测试了你的修改,仍然会有大量Warnings。

@Wong4j
Copy link
Collaborator

Wong4j commented Jul 31, 2023

warning信息简化一下,主要有两个地方,分别是data_feeder.pyexecutor.py报的。

1574: /opt/paddle/paddle/build/python/paddle/fluid/data_feeder.py:186: UserWarning: The data type of 'dtype' in cast only support bfloat16 in OneDNN now.
1574:   warnings.warn(
1574: /opt/paddle/paddle/build/python/paddle/fluid/data_feeder.py:186: UserWarning: The data type of 'input' in LayerNorm only support bfloat16 in OneDNN now.
1574:   warnings.warn(
1574: /opt/paddle/paddle/build/python/paddle/fluid/data_feeder.py:186: UserWarning: The data type of 'x' in cast only support bfloat16 in OneDNN now.
1574:   warnings.warn(
1574: /opt/paddle/paddle/build/python/paddle/fluid/data_feeder.py:186: UserWarning: The data type of 'dtype' in cast only support bfloat16 in OneDNN now.
1574:   warnings.warn(
1574: /opt/paddle/paddle/build/python/paddle/fluid/executor.py:1479: UserWarning: There are no operators in the program to be executed. If you pass 
Program manually, please use fluid.program_guard to ensure the current Program is being used.

@luotao1
Copy link
Contributor

luotao1 commented Jul 31, 2023

skip bf16相关的改动合理,但并不是root cause。我刚才再次在A100上测试了你的修改,仍然会有大量Warnings。

@Wong4j 那能否先合入这个PR, @RedContritio 再看看如何修复 data_feeder.py和executor.py 引起的 wanirng?

@Wong4j
Copy link
Collaborator

Wong4j commented Jul 31, 2023

skip bf16相关的改动合理,但并不是root cause。我刚才再次在A100上测试了你的修改,仍然会有大量Warnings。

@Wong4j 那能否先合入这个PR, @RedContritio 再看看如何修复 data_feeder.py和executor.py 引起的 wanirng?

可以

Copy link
Collaborator

@Wong4j Wong4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luotao1 luotao1 merged commit 4df4b9f into PaddlePaddle:develop Jul 31, 2023
@RedContritio RedContritio deleted the fix_test_layer_norm_warning branch August 5, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants