Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sharding optim] Optim check finite #55766

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Jul 28, 2023

PR types

Others

PR changes

Others

Description

Only check local params for sharding stage 1 under comm overlap.

image

PCard-70444

@paddle-bot
Copy link

paddle-bot bot commented Jul 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu closed this Jul 28, 2023
@FeixLiu FeixLiu deleted the optim_check_finite branch July 28, 2023 04:51
@FeixLiu FeixLiu restored the optim_check_finite branch July 28, 2023 04:53
@FeixLiu FeixLiu reopened this Jul 28, 2023
@FeixLiu FeixLiu force-pushed the optim_check_finite branch from 6759366 to 9da5c2c Compare July 30, 2023 11:17
Optimize check finite when using sharding comm overlap.
@FeixLiu FeixLiu force-pushed the optim_check_finite branch from be0eef4 to e14e207 Compare July 31, 2023 02:28
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu merged commit a00f5bd into PaddlePaddle:develop Aug 1, 2023
@FeixLiu FeixLiu deleted the optim_check_finite branch August 1, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants