[NewIR]Codegen templete of Op vjp interface #56196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
changed the title
Aurelius84
previously approved these changes
Aug 14, 2023
| """ | ||
|
|
||
| OP_VJP_DEFINE_TEMPLATE = """ | ||
| std::vector<std::vector<ir::OpResult>> {op_class_name}::Vjp( |
There was a problem hiding this comment.
这里的签名是 vector of vector，意味着这一层接口之外是不需要再考虑 combine 和 slice了，所有的pack和unpack都在 vjp 函数里默认做了？
Co-authored-by: Aurelius84 <[email protected]>
zhangbo9674
approved these changes
Aug 14, 2023
| @@ -22,6 +22,86 @@ | |||
| }} | |||
| """ | |||
|
|
|||
| OP_VJP_FORWARD_INPUT_OR_OUTPUT_TEMPLATE = """ | |||
| {input_type} {input_name}(std::make_shared<primitive::experimental::DescTensor>(op_obj.{input_name}())); | |||
There was a problem hiding this comment.
这份代码将生成在 paddle::dialect namespace 下吧？primitive::experimental 是不是需要加上 paddle namespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
paddle.dialect 下op定义生成vjp调用接口模版
TODO 解析模版参数生成有效内容
pcard-67164