[NewIR] support c_sync_calc_stream/c_sync_comm_stream/send_v2/recv_v2 #56557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x45f
reviewed
Aug 28, 2023
| @@ -263,7 +286,15 @@ def _gen_one_impl(self, op_info, op_name): | |||
| attr_name_list = op_info.attribute_name_list | |||
| mutable_attr_name_list = op_info.mutable_attribute_name_list | |||
| no_mutable_attr_name_list = op_info.non_mutable_attribute_name_list | |||
| if len(mutable_attr_name_list) > 0: | |||
|
|
|||
| if op_name == "send_v2": | |||
There was a problem hiding this comment.
output_name_list = op_info.output_name_list
if len(output_name_list) == 0:
xxx
这里是不是可以修改成上面的代码，通过输出个数判断，而不是名字判断， 这样如果后面还有0输出的api也可以正常生成
There was a problem hiding this comment.
Fix in the next PR.
zyfncg
approved these changes
Aug 29, 2023
Comment on lines
+76
to
+81
| void SendV2InferMeta(const int peer, const int ring_id); | ||
|
|
||
| void RecvV2InferMeta(int peer, | ||
| DataType dtype, | ||
| const std::vector<int>& out_shape, | ||
| MetaTensor* out); |
There was a problem hiding this comment.
这两个InferMeta函数要放在nullary.h/cc文件中，后续再提个PR改一下
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
…PaddlePaddle#56557) * [AutoParallel][NewIR] support calc_sync/comm_sync/send_v2/recv_v2 * pre-commit * rm unittest * tiny fix * api_gen support send_v2's output is empty * fix format * python_c_gen support send_v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description
Pcard-67164