-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NewIR]new ir support yaml backend config #56570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix_new_ir_seg_bug
… fix_new_ir_seg_bug
zhangbo9674
reviewed
Aug 24, 2023
} else if (input_map.count(slot_name)) { | ||
// parse from input | ||
int in_index = input_map.at(slot_name); | ||
auto type = map_value_pair.at(op->operand_source(in_index)).type(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么一定要用 opresult 获取 type?
return kernel_data_type; | ||
} | ||
|
||
phi::Backend GetKernelBackendByYamlInfo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetKernelBackendByYamlInfo 和 GetKernelDataTypeByYamlInfo 的内容几乎是一样的,后续可以合并成一个
zhangbo9674
previously approved these changes
Aug 24, 2023
… fix_new_ir_seg_bug
zhangbo9674
approved these changes
Aug 25, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
* update * fix comile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
在op的yaml定义中,会指定backend的选择方式,该PR是支持这种设定
Others
Pcard-67164