Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approval for using cc_test_old #56715

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add approval for using cc_test_old #56715

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62e88d7
add cc_test_old approve,test=document_fix
risemeup1 Aug 30, 2023
bea1fd4
add cc_test_old approve,test=document_fix
risemeup1 Aug 30, 2023
c08048d
add cc_test_old approve,test=document_fix
risemeup1 Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/check_file_diff_approvals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,12 @@ if [ "${HAS_MODIFIED_DECLARATIONS}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
check_approval 1 chenwhql zyfncg
fi

HAS_USED_CCTESTOLD=`git diff -U0 upstream/$BRANCH |grep "cc_test_old" || true`
if [ "${HAS_USED_CCTESTOLD}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must be approved by phlrain or risemeup1(liujiaodi) or zhangbo9674 for using cc_test_old. Thanks!\n"
check_approval 1 phlrain risemeup1 zhangbo9674
fi

HAS_MODIFIED_API_COMPAT_YAML=`git diff --name-only upstream/$BRANCH | grep "paddle/phi/api/yaml/op_compat.yaml" || true`
if [ "${HAS_MODIFIED_API_COMPAT_YAML}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must be approved by chenwhql or zyfncg or heavyrain-lzy for paddle/phi/api/yaml/op_compat.yaml changes, which manages the extra params of Op and name mapping between Yaml and OpMaker. In order to ensure compatibility of framework, this file isn't allowed to be modified at will!\n"
Expand Down