[PIR] Add shapedtype interface unit test #57337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbopd
changed the title
zhangbo9674
previously approved these changes
Sep 15, 2023
winter-wang
reviewed
Sep 15, 2023
winter-wang
reviewed
Sep 15, 2023
winter-wang
reviewed
Sep 15, 2023
winter-wang
reviewed
Sep 15, 2023
| namespace details { | ||
| namespace pir { | ||
|
|
||
| namespace detail { | ||
|
|
||
| template <typename RangeT> | ||
| constexpr auto begin_impl(RangeT &&range) |
There was a problem hiding this comment.
没太看懂，这个begin_impl函数是必需的吗？ 后面的end_impl类似。
zhangbo9674
approved these changes
Sep 18, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* Add shapedtype interface unit test * fix windows CI for not support cxx17
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* Add shapedtype interface unit test * fix windows CI for not support cxx17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Other
Pcard-67164