Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【CINN】add IRCompare Interface for ir_equal_visitor and move it from namespace optim to ir_utils #57531

Merged

Conversation

Courtesy-Xs
Copy link
Contributor

PR types

Others

PR changes

Others

Description

pcard-72718
This PR add IRCompare interface and hide IrEqualVisitor implementation, meanwhile move it from namespace optim to ir_utils

@paddle-bot
Copy link

paddle-bot bot commented Sep 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Courtesy-Xs Courtesy-Xs changed the title 【CINN】add API for ir_compare and move it from namespace optim to ir_utils 【CINN】add IRCompare Interface for ir_equal_visitor and move it from namespace optim to ir_utils Sep 20, 2023
@@ -23,7 +23,7 @@

namespace cinn {
namespace ir {

namespace ir_utils {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个test不用加namespace吧?

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants