Fix NaN for softmax with long softmax_dim. #57851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Xreki
changed the title
|
Sorry to inform you that 15089a9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Xreki
force-pushed
the
op/fix_softmax_nan
branch
from
7fca389 to
06033bb
Compare
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* Fix nan for softmax with long softmax_dim. * Simplify codes. * Remove the PADDLE_THROW in backward.
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* Fix nan for softmax with long softmax_dim. * Simplify codes. * Remove the PADDLE_THROW in backward.
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* Fix nan for softmax with long softmax_dim. * Simplify codes. * Remove the PADDLE_THROW in backward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Description
Pcard-70459
softmax函数出现NaN #55685 ，softmax长维度分支、前向结果在小输入数据出现NaN问题。KeMatrixSoftmaxForward代码，主要包括以下几点：BatchSize模板，外层实际传入的为BlockDim，Kernel中实际并没有用到，增大了编译负担VecSize模板，对于每种数据类型，使用的VecSize是固定的，没有必要为多种VecSize特化switch的default分支添加报错信息；反向添加报错后，log_softmax算子单测会fail，待反向计算问题解决后再添加。