Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][ruff] clean some F401 step: 2 #57970

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Oct 9, 2023

@paddle-bot
Copy link

paddle-bot bot commented Oct 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gouzil gouzil changed the title [codestyle] clean some F401 step: 2 [codestyle][ruff] clean some F401 step: 2 Oct 9, 2023
@paddle-bot paddle-bot bot added the contributor External developers label Oct 9, 2023
@SigureMo SigureMo changed the title [codestyle][ruff] clean some F401 step: 2 [CodeStyle][ruff] clean some F401 step: 2 Oct 10, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 10, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些 import 顶层/通用/库切没有标记 F401 的代码优先试试能不能删掉,否则会导致混乱的引用关系

本 PR 暂不修改,之后 PR 再说

LGTMeow 🐾

from .fs import HDFSClient # noqa: F401
from .ps_util import DistributedInfer # noqa: F401
from paddle.utils import deprecated
import paddle # noqa: F401
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

from paddle.distributed import fleet
from paddle.utils import deprecated # noqa: F401
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2

@@ -12,8 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import multiprocessing # noqa: F401
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3

@luotao1 luotao1 merged commit 92d2d1e into PaddlePaddle:develop Oct 11, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* [codestyle] clean F401

* fix parallel_layers

* try fix asp

* fix fuse_resnet_unit_pass

* fix dy2static

* fix meta_parallel
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* [codestyle] clean F401

* fix parallel_layers

* try fix asp

* fix fuse_resnet_unit_pass

* fix dy2static

* fix meta_parallel
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* [codestyle] clean F401

* fix parallel_layers

* try fix asp

* fix fuse_resnet_unit_pass

* fix dy2static

* fix meta_parallel
@gouzil gouzil deleted the noqa_clean_4 branch January 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants