[PIR] Refine if translate #58250
Merged
[PIR] Refine if translate #58250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
approved these changes
Oct 23, 2023
| uint64_t start_id, | ||
| uint64_t end_id, | ||
| TranslationContext* translation_ctx, | ||
| pir::Block* dest_block, |
There was a problem hiding this comment.
Suggested change
| pir::Block* dest_block, | |
| pir::Block* dst_block, |
| pir::Block* dest_block, | ||
| bool for_cond_block = false, | ||
| std::vector<std::string> cond_sub_block_outputs = {}, | ||
| std::vector<::paddle::framework::OpDesc*> cond_init_ops = {}); |
There was a problem hiding this comment.
这里两个默认参数是不是也可以 const & ?
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
* refine * fix * fix * fix * fix * fix * add ut * fix * fix
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
* refine * fix * fix * fix * fix * fix * add ut * fix * fix
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* refine * fix * fix * fix * fix * fix * add ut * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
优化 if 翻译
Pcard-67164