Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【pir】modify FusedMatmulAddGradAddPattern #58537

Merged
merged 8 commits into from
Nov 6, 2023

Conversation

xiaoguoguo626807
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 commented Oct 31, 2023

PR types

others

PR changes

others

Description

pcard-67164
修复pass

@paddle-bot paddle-bot bot added the contributor External developers label Oct 31, 2023
Copy link

paddle-bot bot commented Nov 2, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
Aurelius84
Aurelius84 previously approved these changes Nov 3, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -104,6 +106,18 @@ StandaloneExecutor::StandaloneExecutor(const platform::Place& place,
"@fetch";
}
}

if (FLAGS_enable_fused_pass) {
pir::PassManager pm(pir::IrContext::Instance());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PassManger 在前端也已经bind出来了,后续是否可以考虑支持在Python端管理和开启Pass 的机制?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前仅为临时测试使用,后续可结合python端pass一起设计开关

@xiaoguoguo626807 xiaoguoguo626807 merged commit 3eb1a79 into PaddlePaddle:develop Nov 6, 2023
@xiaoguoguo626807 xiaoguoguo626807 deleted the pass branch November 6, 2023 02:43
@xiaoguoguo626807 xiaoguoguo626807 changed the title 【pir】add fused Pass for new executor 【pir】modify FusedMatmulAddGradAddPattern Nov 6, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
* modify

* modify

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* code style

* delete flag

* Update paddle/fluid/framework/new_executor/standalone_executor.cc
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* modify

* modify

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* code style

* delete flag

* Update paddle/fluid/framework/new_executor/standalone_executor.cc
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* modify

* modify

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* Update paddle/fluid/pir/transforms/fusion/fused_linear_param_grad_add_pass.cc

* code style

* delete flag

* Update paddle/fluid/framework/new_executor/standalone_executor.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants