Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] Remove p2r in forward api #58644

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Nov 3, 2023

PR types

Function optimization

PR changes

Others

Description

Pcard-73145

[AutpParallel] Remove p2r in forward api

去掉前向API输出强制Partial转Replicate的逻辑,支持后续Sharding实现

  • 支持reduce mean下,Replicated到partial的转换
  • 修复Replicated到partial状态下,用全局shape构造全零张量,导致hang的问题
  • 新增matmul反向推导修改Input dist_attr的逻辑
  • 修复elementwise前向推导partial状态没清除的问题

八卡mp+dp+pp混合策略本地已跑通

image

Copy link

paddle-bot bot commented Nov 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@chenwhql chenwhql changed the title [AutpParallel] Remove p2r in forward api [AutoParallel] Remove p2r in forward api Nov 3, 2023
LiYuRio
LiYuRio previously approved these changes Nov 7, 2023
Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiYuRio LiYuRio force-pushed the ap/remove_p2r_in_forward branch 5 times, most recently from bf3cd8c to ed0b04a Compare November 13, 2023 03:16
@LiYuRio LiYuRio force-pushed the ap/remove_p2r_in_forward branch from ed0b04a to d0aaf01 Compare November 13, 2023 03:19
Copy link
Contributor

@GhostScreaming GhostScreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiYuRio LiYuRio merged commit 3bbb89c into PaddlePaddle:develop Nov 13, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* remove p2r in forward api

* support reduce mean in r to p

* test only

---------

Co-authored-by: LiYuRio <[email protected]>
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* remove p2r in forward api

* support reduce mean in r to p

* test only

---------

Co-authored-by: LiYuRio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants