Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.22】Migrate paddle.nn.functional.bilinear into pir #58690

Merged
merged 5 commits into from
Nov 14, 2023
Merged

【PIR API adaptor No.22】Migrate paddle.nn.functional.bilinear into pir #58690

merged 5 commits into from
Nov 14, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 4, 2023

PR types

Others

PR changes

Others

Description

Migrate paddle.nn.functional.bilinear into pir

@paddle-bot paddle-bot bot added the contributor External developers label Nov 4, 2023
@luotao1 luotao1 mentioned this pull request Nov 6, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 6, 2023
MarioLulab
MarioLulab reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/legacy_test/test_layers.py 里有 paddle.nn.Bilinear 相关的单测，麻烦补一下吧~ 😃

@MarioLulab
Copy link
Contributor

MarioLulab commented Nov 8, 2023 •
edited
Loading

ci 挂在了 test_layers.py 中的 self.get_static_graph_result 函数里。这个 PR 会对这一类的问题进行 fix #58608
待问题 fix 之后再推进这个 pr 的合入吧~

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 10, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MarioLulab
Copy link
Contributor

ci 挂在了 test_layers.py 中的 self.get_static_graph_result 函数里。这个 PR 会对这一类的问题进行 fix #58608 待问题 fix 之后再推进这个 pr 的合入吧~

这个 pr 已经合入了。麻烦 merge 一下最新的 develop 分支，再跑一下 ci 看是否会报错~

MarioLulab
MarioLulab approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GreatV GreatV requested review from 0x45f and YuanRisheng November 14, 2023 02:02
@0x45f 0x45f merged commit 9528c7e into PaddlePaddle:develop Nov 14, 2023
@GreatV GreatV deleted the pir_F_bilinear branch November 14, 2023 03:19
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@GreatV
【PIR API adaptor No.22】Migrate paddle.nn.functional.bilinear into pir (…
7a37113 
…PaddlePaddle#58690)
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@GreatV @SecretXV
【PIR API adaptor No.22】Migrate paddle.nn.functional.bilinear into pir (…
88877ba 
…PaddlePaddle#58690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

@MarioLulab MarioLulab MarioLulab approved these changes

@YuanRisheng YuanRisheng Awaiting requested review from YuanRisheng

Assignees

@luotao1 luotao1

@0x45f 0x45f

@YuanRisheng YuanRisheng

@MarioLulab MarioLulab

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GreatV @MarioLulab @0x45f @luotao1 @YuanRisheng