[Semi-Auto]Add master_grad for semi-auto parallel in AMP #58706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForFishes
force-pushed
the
add_master_grad
branch
from
9d26bd5 to
dbdd187
Compare
ForFishes
changed the title
ForFishes
force-pushed
the
add_master_grad
branch
from
b1f295a to
c95983f
Compare
chenwhql
reviewed
Nov 8, 2023
| from paddle import nn | ||
|
|
||
|
|
||
| class TestSimpleNetWithAmpForSemiAutoParallel(TestSimpleNetForSemiAutoParallel): |
There was a problem hiding this comment.
和amp那个单测重名，且内容重合度也比较高，如果主要是master_grad参数的变化，要不要整理复用一下代码
There was a problem hiding this comment.
i will merge them together.
test/amp/test_amp_master_grad.py
Outdated
| @@ -54,7 +54,7 @@ def check_results( | |||
| ) | |||
| self.assertEqual( | |||
| int(op_list['transfer_dtype'].split(',')[0]), | |||
| total_steps + total_steps * 2, | |||
| total_steps + total_steps * 2 + 2, # add 2 for adam's master grad | |||
ForFishes
force-pushed
the
add_master_grad
branch
from
11d61bd to
fd5e31f
Compare
XieYunshen
approved these changes
Nov 9, 2023
LiYuRio
approved these changes
Nov 9, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…e#58706) * fix confilct * fix confilct * fix confilct * fix confilct * fix confilct
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…e#58706) * fix confilct * fix confilct * fix confilct * fix confilct * fix confilct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
Others
Description
[Distributed]Add utest for semi-auto parallel
Pcard-73145