-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR API adaptor No.17、33、72、101、121、125】Migrate paddle.atan2,paddle.deg2rad,paddle.floor_divide,paddle.heaviside,paddle.kron,paddle.lerp into pir #58718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MarioLulab
suggested changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work~
但还有些小问题需要修改 🚀
MarioLulab
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0x45f
approved these changes
Nov 9, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…deg2rad,paddle.floor_divide,paddle.heaviside,paddle.kron,paddle.lerp into pir (PaddlePaddle#58718)
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…deg2rad,paddle.floor_divide,paddle.heaviside,paddle.kron,paddle.lerp into pir (PaddlePaddle#58718)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
No.17、33、72、101、121、125
将
paddle.atan2
迁移升级至 pir,并更新单测 7/7将
paddle.deg2rad
迁移升级至 pir,并更新单测 0/1将
paddle.floor_divide
迁移升级至 pir,并更新单测 6/7将
paddle.heaviside
迁移升级至 pir,并更新单测 7/7将
paddle.kron
迁移升级至 pir,并更新单测 7/7将
paddle.lerp
迁移升级至 pir,并更新单测 13/13floor_divide的static_test:
目前 test_name 相关的单测还不支持。所以这个单测应该没法切换到 pir 模式下。所以这个单测跳过
deg2rad中的static_test报错: