Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.17、33、72、101、121、125】Migrate paddle.atan2,paddle.deg2rad,paddle.floor_divide,paddle.heaviside,paddle.kron,paddle.lerp into pir #58718

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 6, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
No.17、33、72、101、121、125
paddle.atan2 迁移升级至 pir,并更新单测 7/7
paddle.deg2rad 迁移升级至 pir,并更新单测 0/1
paddle.floor_divide 迁移升级至 pir,并更新单测 6/7
paddle.heaviside 迁移升级至 pir,并更新单测 7/7
paddle.kron 迁移升级至 pir,并更新单测 7/7
paddle.lerp 迁移升级至 pir,并更新单测 13/13

floor_divide的static_test:
目前 test_name 相关的单测还不支持。所以这个单测应该没法切换到 pir 模式下。所以这个单测跳过

deg2rad中的static_test报错:

2023-11-07 17:00:50 ======================================================================
2023-11-07 17:00:50 FAIL: test_static_graph (test_deg2rad.TestDeg2radAPI)
2023-11-07 17:00:50 ----------------------------------------------------------------------
2023-11-07 17:00:50 Traceback (most recent call last):
2023-11-07 17:00:50   File "C:\home\workspace\Paddle\build\python\paddle\pir_utils.py", line 113, in impl
2023-11-07 17:00:50     func(*args, **kwargs)
2023-11-07 17:00:50   File "C:\home\workspace\Paddle\build\test\legacy_test\test_deg2rad.py", line 58, in test_static_graph
2023-11-07 17:00:50     self.assertTrue((res == self.out_np).all())
2023-11-07 17:00:50 AssertionError: False is not true

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 8, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work~
但还有些小问题需要修改 🚀

test/legacy_test/test_kron_op.py Show resolved Hide resolved
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 1d786c8 into PaddlePaddle:develop Nov 9, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…deg2rad,paddle.floor_divide,paddle.heaviside,paddle.kron,paddle.lerp into pir (PaddlePaddle#58718)
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
…deg2rad,paddle.floor_divide,paddle.heaviside,paddle.kron,paddle.lerp into pir (PaddlePaddle#58718)
@enkilee enkilee deleted the pir-api-some branch December 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants