[PIR] Rewrite dead_code_elimination_pass, delete reorder_block_ops_pass and fix constant_folding_pass #58732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanlehome
changed the title
yuanlehome
force-pushed
the
fix_dce_pass
branch
from
3291ca7 to
bef7950
Compare
yuanlehome
force-pushed
the
fix_dce_pass
branch
from
bef7950 to
5a43560
Compare
yuanlehome
changed the title
zyfncg
approved these changes
Nov 7, 2023
| void Run(pir::Operation* op) override { | ||
| pir::GreedyRewriteConfig cfg; | ||
| cfg.use_top_down_traversal = true; | ||
| cfg.max_iterations = 10; |
There was a problem hiding this comment.
Why this magic number？
There was a problem hiding this comment.
It controls the number of iterations and patterns during full graph matching.
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Nov 7, 2023
…ss and fix constant_folding_pass (PaddlePaddle#58732) * fix dead_code_elimination_pass and delete reorder_block_ops_pass * update * update * update * update * update
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
…ss and fix constant_folding_pass (PaddlePaddle#58732) * fix dead_code_elimination_pass and delete reorder_block_ops_pass * update * update * update * update * update
|
你的PR提交成功，感谢你对开源项目的贡献! |
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…ss and fix constant_folding_pass (PaddlePaddle#58732) * fix dead_code_elimination_pass and delete reorder_block_ops_pass * update * update * update * update * update
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…ss and fix constant_folding_pass (PaddlePaddle#58732) * fix dead_code_elimination_pass and delete reorder_block_ops_pass * update * update * update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Others
Pcard-71500