[PIR] Support while grad exe #59496
Merged
[PIR] Support while grad exe #59496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/Paddle into dev/pir_while_exe
chen2016013
reviewed
Nov 30, 2023
| @@ -44,11 +44,13 @@ class HasElementsInstruction : public InstructionBase { | |||
|
|
|||
| std::string name_{"has_elelments_instruction"}; | |||
|
|
|||
| const platform::DeviceContext* dev_ctx_; // not owned | |||
| // const platform::DeviceContext* dev_ctx_; // not owned | |||
chen2016013
reviewed
Nov 30, 2023
| uint64_t num) { | ||
| std::stack<const Variable*> rtn; | ||
| for (uint64_t i = 0; i < num; i++) { | ||
| rtn.push(var_array->at(var_array->size() - 1)); |
There was a problem hiding this comment.
push var_array的最后一个元素，是不是可以给var_array提供一个back()接口？
winter-wang
reviewed
Nov 30, 2023
| /// ... | ||
| /// } | ||
| /// | ||
| class IR_API HasElementsOp : public pir::Op<HasElementsOp> { |
There was a problem hiding this comment.
都移到上面了，这个IR_API是不是可以删了？
winter-wang
reviewed
Nov 30, 2023
| /// in the While usage scenario. Example: | ||
| /// (%stack_0, %inlet_0, %outlet_0) = "cf.create_stack" () | ||
| /// ... | ||
| /// (%0) = "cf.has_elements" (%stack_0) |
winter-wang
reviewed
Nov 30, 2023
| auto var_array = value_exe_info_->GetVarByValue(stack_value); | ||
| stack_element_var_array_ = var_array->GetMutable<VariableRefArray>(); | ||
| } | ||
|
|
||
| void HasElementsInstruction::Run() { | ||
| VLOG(6) << "run has_elements instruction"; | ||
| bool is_empty = stack_element_var_array_->size(); |
There was a problem hiding this comment.
这个 stack_element_var_array_没有empty接口吗？调用size()，返回bool值感觉有点奇怪
There was a problem hiding this comment.
好建议，目前没有，后面我添加一下
Aurelius84
approved these changes
Dec 1, 2023
| IR_ENFORCE(num_results() == 1u, "The size of outputs must be equal to 1."); | ||
| IR_ENFORCE((*this)->result_type(0).isa<DenseTensorType>() || | ||
| (*this)->result_type(0).isa<AllocatedDenseTensorType>(), | ||
| "The type of cf.has_elements' output is not correct."); |
There was a problem hiding this comment.
Suggested change
| "The type of cf.has_elements' output is not correct."); | |
| "The type of pd_op.has_elements' output is not correct."); |
From00
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
支持 while grad 执行
Pcard-67164