[Dy2St] Add enable_to_static_guard for dy2st uts
#59670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
commented
Dec 5, 2023
| original_flag_value = program_translator.enable_to_static | ||
| program_translator.enable(flag) | ||
| try: | ||
| program_translator.enable(flag) |
SigureMo
commented
Dec 5, 2023
Comment on lines
+506
to
+511
| # Why need set `_in_to_static_mode_` here? | ||
| # In Dy2St we use `with _to_static_mode_guard_()` to indicate | ||
| # that the code block is under @to_static, but in this UT | ||
| # an exception is thrown during Dy2St, making the `_in_to_static_mode_` | ||
| # a wrong value. So We need set `_in_to_static_mode_` to False manually. | ||
| paddle.base.dygraph.base.global_var._in_to_static_mode_ = False |
There was a problem hiding this comment.
这里看起来也不需要了，因为现在 _to_static_mode_guard_ 有 try-finally 确保恢复 _in_to_static_mode_，之后删一下
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
增加
enable_to_static_guard以免泄漏 enable_to_static 状态到单测外PCard-66972