Support opt save load #59843
Merged
Support opt save load #59843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhiqiu
reviewed
Dec 8, 2023
| @@ -399,6 +405,8 @@ def load_state_dict( | |||
| paddle.distributed.init_parallel_env() | |||
|
|
|||
| rank_to_files = get_rank_to_files(path, state_dict, process_group, use_dist) | |||
| if len(rank_to_files) <= 0: | |||
| @@ -55,6 +55,12 @@ def get_rank_to_files(path, state_dict, process_group, use_dist): | |||
| if local_tensor_index.tensor_key in state_dict: | |||
| necessary_files.append(file_name) | |||
| necessary_data_files_set = set(necessary_files) | |||
| if len(necessary_data_files_set) <= 0: | |||
There was a problem hiding this comment.
嗯是不会有，但是也不影响正确性，习惯性这样写了。可修改
Comment on lines
+511
to
+519
| for param in param_list: | ||
| if param.stop_gradient: | ||
| continue | ||
| if hasattr(param, "main_grad"): | ||
| if param.main_grad is not None: | ||
| return state_dict | ||
| else: | ||
| if param.grad is not None: | ||
| return state_dict |
There was a problem hiding this comment.
I think it is a little bit trick
There was a problem hiding this comment.
暂时没有想到更好的做法，这里就先考虑这样，后面再思考是否有更好做法
zhiqiu
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
card-78318
support semi-auto optimizer save load