Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pir):fix bug layer_norm kernel error when run in pir with amp_o2 … #68543

Merged

Conversation

blacksheep-Aristotle
Copy link
Contributor

@blacksheep-Aristotle blacksheep-Aristotle commented Sep 30, 2024

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

when use_promote , layer_norm bias and scale should cast to fp32 when input is fp32.

…use_promote

	when use_promote , layer_norm bias and scale should cast to fp32 when input is fp32.
Copy link

paddle-bot bot commented Sep 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 30, 2024
Copy link

paddle-ci-bot bot commented Oct 8, 2024

Sorry to inform you that 06f0745's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit dcca128 into PaddlePaddle:develop Oct 10, 2024
26 of 27 checks passed
@blacksheep-Aristotle blacksheep-Aristotle deleted the fix_layer_norm_amp_bug branch October 10, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants