fix core: auto growth allocator add release lock #68631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… auto_growth_allocator_add_release_lock
|
你的PR提交成功，感谢你对开源项目的贡献! |
Wangzheee
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
Bug fixes
Description
AutoGrowthBestFitAllocator作为默认的显存分配器，它是进程级的，在创建predictor时会调用ReleaseImpl释放空闲的chunks，但是ReleaseImpl不是线程安全的，如果此时其他predictor正在分配或者释放显存，会导致进程core；
所以修复方式是：参考FreeImpl和AllocateImpl接口实现，在ReleaseImpl中添加自旋锁，防止并发错误。