-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HEU][CodeStyle][Typos][B-[3-7]] Fix typo(befor
, befores
, begining
,benfit
,Betweent
,betweeen
,bindins
)
#69640
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
befor
, befores
, begining
,benfit
,Betweent
,betweeen
,bindins
)
auto& befores = ops_before_[i]; | ||
for (auto before_op : befores) { | ||
auto& before = ops_before_[i]; | ||
for (auto before_op : before) { | ||
for (auto behind_op : behinds) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
从语义上来看,这里 befores
表示的是复数个 before 的 OP,因此可以将其命名改为 before_ops
,确保一致性,behinds
也改为 behind_ops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#69650 重排了下配置顺序,麻烦解决下冲突 |
已解决 |
没有解决冲突 |
您好,想问一下,我只能改成和最新的分支一样的吗,我想删除我已经修改过的部分,但是会报冲突的错误 |
git checkout develop
git pull
git checkout fix-typos
git checkout develop -- _typos.toml
git commit -m 'restore `_typos.toml`'
# 重新修改 `_typos.toml`
git add _typos.toml
git commit -m 'update `_typos.toml`' 只是建议,自己判断是否应该这样做,出问题别找我,自己搜索解决 |
实在不行你把 https://github.com/PaddlePaddle/Paddle/blob/develop/_typos.toml 的内容粘贴一下啊…… |
我把内容换成和develop一样的是不会报冲突的,但我想把我改过的删除掉,一修改就会报错, |
不懂,冲突解决是基础,自己学习下吧 |
@MrXnneHang 您好,想问一下PR-CI-APPROVAL没通过,需要别人APPROVAL的情况该怎么做呢 |
就是字面意思,需要RD批准,耐心等待即可。 |
befor
, befores
, begining
,benfit
,Betweent
,betweeen
,bindins
)befor
, befores
, begining
,benfit
,Betweent
,betweeen
,bindins
)
PR Category
User Experience
PR Types
Devs
Description
Fix: