Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][G-[6-8]] Fix typos(Greate,groupped,GARD,gard) #70540

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Dec 30, 2024

PR Category

User Experience

PR Types

Devs

Description

fixed:
Greate,
groupped,
GARD,
gard

@enkilee enkilee requested a review from SigureMo as a code owner December 30, 2024 02:34
Copy link

paddle-bot bot commented Dec 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 30, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 30, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要解决下冲突

@@ -23,7 +23,7 @@

namespace {

// add_grad + matmul_grad + add_ -> matmul + fused_liner_param_grad_add
// add_grad + matmul_grad + add_ -> matmul + fused_linear_param_grad_add
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不止这一个地方呀 😂

@SigureMo SigureMo requested a review from Copilot December 30, 2024 04:53

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • paddle/fluid/pir/transforms/gpu/fused_linear_param_grad_add_pass.cc: Language not supported
  • paddle/fluid/pir/transforms/tensorrt/trt_op_marker_pass.cc: Language not supported
  • paddle/phi/kernels/cpu/i0e_grad_kernel.cc: Language not supported
  • paddle/phi/kernels/cpu/polygamma_grad_kernel.cc: Language not supported
  • paddle/phi/kernels/funcs/sparse/softmax.cu.h: Language not supported
  • paddle/fluid/pir/dialect/op_generator/op_gen.py: Evaluated as low risk
@@ -124,10 +124,6 @@ funcion = 'funcion'
Funcion = 'Funcion'
futher = 'futher'
furture = 'furture'
Greate = 'Greate'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 PR 和另一个又会冲突吧……

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议大力出奇迹

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?怎么还教唆别人呢 给你一拳

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit b914a8c into PaddlePaddle:develop Dec 30, 2024
29 checks passed
@enkilee enkilee deleted the typo-g6 branch January 21, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants