Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][I-[1-10]] Fix typo(identiy,indentify,implemention,implementd,implementated,impliment,implment,implicitely,Inproper,inconsistence,uncorrectly,Indext) #70558

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

yinfan98
Copy link
Contributor

PR Category

User Experience

PR Types

Others

Description

fix typos~ I1-I10
很不幸触发到cpplint的trigger了,顺便把optional.h 里的 cpplint 修了一下orz。

@yinfan98 yinfan98 requested a review from SigureMo as a code owner December 30, 2024 11:25
Copy link

paddle-bot bot commented Dec 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 30, 2024
@SigureMo
Copy link
Member

冲突了冲突了,一个 PR 冲突了俩 [doge]

@SigureMo
Copy link
Member

这么快的解

@yinfan98
Copy link
Contributor Author

这么快的解

网页端操作的神

SigureMo
SigureMo previously approved these changes Dec 30, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很不幸触发到cpplint的trigger了

确实不幸,这么久了都没遇到过要改这块的

LGTMeow 🐾

@SigureMo
Copy link
Member

不是很好解的适当可以 // NOLINT

@SigureMo
Copy link
Member

另外这个和 #70542 应该还会再冲突一次,猜猜谁先跑完 CI

@yinfan98
Copy link
Contributor Author

另外这个和 #70542 应该还会再冲突一次,猜猜谁先跑完 CI

让敏师傅先歇会儿吧

@yinfan98
Copy link
Contributor Author

不是很好解的适当可以 // NOLINT

决定交给后人的智慧了😊

@yinfan98 yinfan98 changed the title [CodeStyle][Typos][I-[1-10]] Fix typo(identiy,indentify,implemention,implementd,implementated,impliment,implment,implicitely,Inproper,inconsistence,uncorrectly,Indext) [CodeStyle][Typos][I-[1-10]] Fix typo(identiy,indentify,implemention,implementd,implementated,impliment,implment,implicitely,Inproper,inconsistence,uncorrectly,Indext ) Dec 30, 2024
@yinfan98 yinfan98 changed the title [CodeStyle][Typos][I-[1-10]] Fix typo(identiy,indentify,implemention,implementd,implementated,impliment,implment,implicitely,Inproper,inconsistence,uncorrectly,Indext ) [CodeStyle][Typos][I-[1-10]] Fix typo(identiy,indentify,implemention,implementd,implementated,impliment,implment,implicitely,Inproper,inconsistence,uncorrectly,Indext) Dec 30, 2024
@SigureMo
Copy link
Member

PR-CI-Distribute-stable 的编译报错看起来和 optional.h 改动还是有关,相关位置可能不太能改得动了,可以考虑都 // NOLINT

@SigureMo
Copy link
Member

SigureMo commented Jan 4, 2025

codestyle 挂了,「网页端操作」?

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 391a1d6 into PaddlePaddle:develop Jan 6, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants