[CINN] Support inferSymbolicShape in cf.tuple_pop #70565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongshaotian
commented
Dec 30, 2024
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Jan 7, 2025
Comment on lines
+179
to
+184
| if (!pushed_shape_data.data().has_value()) { | ||
| out_shape_data = symbol::TensorShapeOrDataDimExprs(shape); | ||
| } else { | ||
| std::vector<symbol::DimExpr> data = pushed_shape_data.data().value(); | ||
| out_shape_data = symbol::TensorShapeOrDataDimExprs(shape, data); | ||
| } |
There was a problem hiding this comment.
这里是为了解除 TensorShapeOrDataDimExprs 的const，copy了一份
gongshaotian
commented
Jan 7, 2025
| // Using an outlet to temporarily store the ShapeOrData of the output of | ||
| // tuple_pop op | ||
| const Value &outlet = stack_create_op.result(2); | ||
| symbol::TensorListShapeOrDataDimExprs outlet_list; |
There was a problem hiding this comment.
这个方案还有个问题，目前是用TensorListShapeOrDataDimExprs存tuple push的所有参数，但tuple_push里还可能会包含combine出来的TensorListShapeOrDataDimExprs类型的shape，就没法表示了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
New features
Description
Pcard-67164
By obtaining the input of cf.tuple_push, support inferSymbolicShape in cf.tuple_pop