Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] Cleanup IrParser based subgraph exporter #70569

Conversation

SigureMo
Copy link
Member

PR Category

Execute Infrastructure

PR Types

Devs

Description

清理已经弃用的基于 IrParser 的 subgraph exporter(#59353#59449 引入),已经可以被 https://github.com/PaddlePaddle/Athenahttps://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/jit/sot/symbolic/export.py 替代

需在 #70534 后合入

PCard-66972

@SigureMo SigureMo requested a review from Copilot December 31, 2024 04:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

python/paddle/jit/dy2static/pir_partial_program.py:10

  • The assignment 'var = None' is redundant and should be removed.
var = None
@SigureMo SigureMo changed the title [Dy2St] Cleanup outdated subgraph exporter [Dy2St] Cleanup IrParser based subgraph exporter Dec 31, 2024
@SigureMo SigureMo requested review from zrr1999 and gouzil December 31, 2024 16:40
@SigureMo SigureMo changed the title [Dy2St] Cleanup IrParser based subgraph exporter [Dy2St][3.13] Cleanup IrParser based subgraph exporter Dec 31, 2024
@SigureMo SigureMo changed the title [Dy2St][3.13] Cleanup IrParser based subgraph exporter [Dy2St] Cleanup IrParser based subgraph exporter Jan 1, 2025
@SigureMo SigureMo changed the title [Dy2St] Cleanup IrParser based subgraph exporter [Dy2St] Cleanup IrParser based subgraph exporte Jan 1, 2025
@SigureMo SigureMo changed the title [Dy2St] Cleanup IrParser based subgraph exporte [Dy2St] Cleanup IrParser based subgraph exporter Jan 1, 2025
@SigureMo SigureMo merged commit c5a5c3f into PaddlePaddle:develop Jan 2, 2025
35 of 37 checks passed
@SigureMo SigureMo deleted the dy2st/cleanup-outdated-subgraph-exporter branch January 2, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants