Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][D-2,F-4,F-18,F-25,I-43,O-3,O-6,O-8,S-20,T-10,T-22,U-14,W-4,W-8,W-12,W-18] Ignore 1-3 letter words to reduce false positives #70623

Merged

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Jan 4, 2025

PR Category

User Experience

PR Types

Devs

Description

1-3 长度的单词误检率过高,因此参考 crate-ci/typos#1079 跳过 1-3 长度的单词,修正部分确实有问题的单词

另外 ignore datasfeeded 这种使用较多甚至有的已经是惯用 API 的 case,ignore 误检的 dota

PCard-66972

@SigureMo SigureMo requested a review from Copilot January 4, 2025 06:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • paddle/fluid/framework/new_executor/instruction/tensorrt_engine_instruction.cc: Language not supported
  • paddle/fluid/operators/tensorrt/tensorrt_engine_op.h: Language not supported
  • paddle/phi/core/memory/allocation/allocator_facade.cc: Language not supported
  • paddle/phi/kernels/funcs/blas/blas.h: Language not supported
Comments suppressed due to low confidence (1)

python/paddle/io/dataloader/dataloader_iter.py:593

  • Corrected the typo 'wll' to 'will'.
# to indices_queue, workers will exit on reading None from
@SigureMo SigureMo changed the title [CodeStyle][Typos] Ignore 1-3 letter words to reduce false positives [CodeStyle][Typos][F-18,F-25,I-43,O-3,O-6,O-8,S-20,T-10,T-22,U-14,W-4,W-8,W-12,W-18] Ignore 1-3 letter words to reduce false positives Jan 4, 2025
@SigureMo SigureMo changed the title [CodeStyle][Typos][F-18,F-25,I-43,O-3,O-6,O-8,S-20,T-10,T-22,U-14,W-4,W-8,W-12,W-18] Ignore 1-3 letter words to reduce false positives [CodeStyle][Typos][D-2,F-18,F-25,I-43,O-3,O-6,O-8,S-20,T-10,T-22,U-14,W-4,W-8,W-12,W-18] Ignore 1-3 letter words to reduce false positives Jan 4, 2025
@SigureMo SigureMo changed the title [CodeStyle][Typos][D-2,F-18,F-25,I-43,O-3,O-6,O-8,S-20,T-10,T-22,U-14,W-4,W-8,W-12,W-18] Ignore 1-3 letter words to reduce false positives [CodeStyle][Typos][D-2,F-4,F-18,F-25,I-43,O-3,O-6,O-8,S-20,T-10,T-22,U-14,W-4,W-8,W-12,W-18] Ignore 1-3 letter words to reduce false positives Jan 4, 2025
@SigureMo SigureMo requested review from zrr1999 and gouzil January 4, 2025 08:33
@SigureMo SigureMo merged commit e005e79 into PaddlePaddle:develop Jan 4, 2025
32 of 33 checks passed
@SigureMo SigureMo deleted the typos/ignore-1-3-letter-words branch January 4, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants