Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][I-11] Fix typos(indexs,Indexs) (part 1) #70809

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 13, 2025

PR Category

User Experience

PR Types

Devs

Description

fixed:
indexs

fixed part:
Indexs

next PR will delete indexs in typos.toml file

@enkilee enkilee requested a review from SigureMo as a code owner January 13, 2025 08:35
Copy link

paddle-bot bot commented Jan 13, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 13, 2025
_typos.toml Show resolved Hide resolved
@SigureMo SigureMo changed the title [CodeStyle][Typos][I-11] Part-1 Fix typos(indexs,Indexs) [CodeStyle][Typos][I-11] Fix typos(indexs,Indexs) (part 1) Jan 13, 2025
_typos.toml Show resolved Hide resolved
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个 PR 也不要太大,控制在 10 个文件左右,这个不是很好 review

paddle/cinn/hlir/pe/elementwise.cc Outdated Show resolved Hide resolved
paddle/cinn/hlir/pe/elementwise.cc Outdated Show resolved Hide resolved
paddle/cinn/hlir/pe/transform.cc Outdated Show resolved Hide resolved
paddle/cinn/hlir/pe/transform.h Outdated Show resolved Hide resolved
@@ -76,15 +76,15 @@ inline void HOSTDEVICE IndexToCoordinate(const IntT index,
}

template <typename IntT>
inline void HOSTDEVICE IndexToCoordinate(const IntT* indexs,
inline void HOSTDEVICE IndexToCoordinate(const IntT* index,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inline void HOSTDEVICE IndexToCoordinate(const IntT* index,
inline void HOSTDEVICE IndexToCoordinate(const IntT* indices,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里下面有个indices了,改成t_indices可否?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那这里就 index 吧,和上面的签名一致

paddle/phi/kernels/sparse/cpu/coalesce_kernel.cc Outdated Show resolved Hide resolved
@@ -76,15 +76,15 @@ inline void HOSTDEVICE IndexToCoordinate(const IntT index,
}

template <typename IntT>
inline void HOSTDEVICE IndexToCoordinate(const IntT* indexs,
inline void HOSTDEVICE IndexToCoordinate(const IntT* index,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那这里就 index 吧,和上面的签名一致

paddle/phi/kernels/sparse/cpu/coalesce_kernel.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/sparse/cpu/coalesce_kernel.cc Outdated Show resolved Hide resolved
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit 45d780b into PaddlePaddle:develop Jan 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants