update layoutxlm/modeling.py #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeyuChen
approved these changes
May 23, 2022
yingyibiao
reviewed
May 25, 2022
| feature_block, axis=0) | ||
| start_idx = i | ||
|
|
||
| if input_ids[batch_id, i] == 1: |
| @@ -911,6 +939,73 @@ def forward( | |||
| return outputs | |||
|
|
|||
|
|
|||
| class LayoutXLMForSequenceClassification(LayoutXLMPretrainedModel): | |||
There was a problem hiding this comment.
这里的 class 名称改为 LayoutXLMForSegmentClassification 更加合适些
There was a problem hiding this comment.
@yingyibiao 为什么呢？不和HF保持一直的目的是？
There was a problem hiding this comment.
HF 里面 LayoutXLMForSequenceClassification class 对应的是图片分类任务，这个 PR 里面的则为文本段落分类任务，所以建议换个名字。
|
Merge then fix by PaddleNLP Team. @yingyibiao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Models
Description
Add a new model to use Sequence feature to do SER task.