fix test_tipc/train logic #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrostML
reviewed
Jul 26, 2022
tests/test_tipc/train.py
Outdated
| sys.exit() | ||
| #if global_step > 100 and global_step < 110: | ||
| # paddle.fluid.core.nvprof_nvtx_pop() | ||
| # paddle.fluid.core.nvprof_nvtx_push(str(global_step)) |
There was a problem hiding this comment.
这个 commit 仅作为草稿，跑完110 step 就停下。
tests/test_tipc/train.py
Outdated
| reader_cost_avg.record(train_reader_cost) | ||
| batch_cost_avg.record(train_batch_cost) | ||
| batch_ips_avg.record(train_batch_cost, sample_per_cards) | ||
| batch_start = time.time() |
There was a problem hiding this comment.
比如 line:151 需要 batch_cost_avg 的数据，所以在 line:145 之前也需要有这么一段代码
There was a problem hiding this comment.
不过是这段代码同时都在 if... & else.. 里，这段逻辑不能共用么？
There was a problem hiding this comment.
batch_start 是否也可以放到 batch 最后，按理时间戳会准确一些。
There was a problem hiding this comment.
batch_start = time.time() 已放到 batch 最后
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
fix xlnet for ips count