Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Add max model input sizes #3127

Merged
merged 9 commits into from
Sep 4, 2022
Merged

[BugFix] Add max model input sizes #3127

merged 9 commits into from
Sep 4, 2022

Conversation

wj-Mcat
Copy link
Contributor

@wj-Mcat wj-Mcat commented Aug 24, 2022

PR types

Bug fixes

PR changes

Models

Description

try to fix: #3124

@wj-Mcat
Copy link
Contributor Author

wj-Mcat commented Aug 24, 2022

this is a big but simple pr. @guoshengCS

guoshengCS
guoshengCS reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@guoshengCS guoshengCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRETAINED_POSITIONAL_EMBEDDINGS_SIZES -> PRETRAINED_POSITIONAL_EMBEDDINGS_SIZES
这里应该是拼写错了

@wj-Mcat
Copy link
Contributor Author

wj-Mcat commented Aug 25, 2022

PRETAINED_POSITIONAL_EMBEDDINGS_SIZES -> PRETRAINED_POSITIONAL_EMBEDDINGS_SIZES 这里应该是拼写错了

确实是有九个文件中的拼写错误了，我这边也已经更新了。

@guoshengCS guoshengCS merged commit e49344f into PaddlePaddle:develop Sep 4, 2022
@wj-Mcat wj-Mcat mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshengCS guoshengCS guoshengCS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG REPORT]: model_max_length of tokenizer is wrong
2 participants
@wj-Mcat @guoshengCS