-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix]update vocab_size in init_config #3260
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3f185fb
update vocab_size in init_config
wj-Mcat 4337678
Merge branch 'develop' into fix-resize-token
ZHUI 611c755
make update_init_config more common
wj-Mcat ba8b9d6
Merge branch 'fix-resize-token' of github.com:wj-Mcat/PaddleNLP into …
wj-Mcat ca95199
Merge branch 'develop' into fix-resize-token
wj-Mcat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ | |
import six | ||
import logging | ||
import inspect | ||
from typing import Optional | ||
from typing import Any, Optional | ||
|
||
import paddle | ||
import numpy as np | ||
|
@@ -546,11 +546,31 @@ def resize_token_embeddings(self, | |
self.base_model.config['vocab_size'] = new_num_tokens | ||
self.vocab_size = new_num_tokens | ||
|
||
# update init_config | ||
self._update_init_config(self.init_config, 'vocab_size', new_num_tokens) | ||
|
||
# TODO([email protected]): add tie_weight. | ||
# TODO(westfish) Add tie_weight to tie the weights between the input embeddings and the output embeddings if needed. | ||
|
||
return new_embeddings | ||
|
||
def _update_init_config(self, init_config: dict, key: str, value: Any): | ||
"""update init_config by <key, value> pair | ||
|
||
Args: | ||
init_config (dict): the init_config instance | ||
key (str): the key field | ||
value (Any): the new value of instance | ||
""" | ||
if key in init_config: | ||
init_config[key] = value | ||
return | ||
|
||
for arg in init_config.get('init_args', []): | ||
if not isinstance(arg, PretrainedModel): | ||
continue | ||
self._update_init_config(arg.init_config, key, value) | ||
|
||
def _get_resized_embeddings( | ||
self, | ||
old_embeddings: nn.Embedding, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
抽离成通用函数