This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
add type checker for stack push(pop) #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
This was referenced Jun 13, 2023
Closed
改一下标题吧，简单翻译成英文 |
NotHaozi
changed the title
SigureMo
approved these changes
Jun 13, 2023
Yeah, It's ok? |
Aurelius84
approved these changes
Jun 13, 2023
zrr1999
pushed a commit
to zrr1999/paddle-symbolic-trace
that referenced
this pull request
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[first issue😘]
解决方案：
self.push检查，和对stack进行inplace操作的地方检查。经检查，目前
inplace操作只有两处，且保证了是Variable，因此选择方法2。