Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug where the scalar chart is not showing time wall properly. #394

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Fix the bug where the scalar chart is not showing time wall properly. #394

merged 2 commits into from
Apr 13, 2018

Conversation

jetfuel
Copy link
Collaborator

@jetfuel jetfuel commented Apr 13, 2018

fix #393

@jetfuel jetfuel self-assigned this Apr 13, 2018
daming-lu
daming-lu previously approved these changes Apr 13, 2018
View reviewed changes
Copy link
Collaborator

@daming-lu daming-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'time wall' should be 'wall time' 😄

@jetfuel jetfuel merged commit 274f455 into PaddlePaddle:develop Apr 13, 2018
@jetfuel jetfuel deleted the wallTimeLabel branch April 13, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daming-lu daming-lu daming-lu approved these changes

@nickyfantasy nickyfantasy Awaiting requested review from nickyfantasy

@deqingli deqingli Awaiting requested review from deqingli

Assignees

@jetfuel jetfuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Scalar Horizontal relative setting and wall setting is showing incorrect result.
2 participants
@jetfuel @daming-lu